Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add a new method fork to create a mutable memtable #10

Merged
merged 5 commits into from
Feb 5, 2024
Merged

feat: Add a new method fork to create a mutable memtable #10

merged 5 commits into from
Feb 5, 2024

Conversation

evenyag
Copy link
Owner

@evenyag evenyag commented Feb 4, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This PR adds a new API fork() to create a new mutable memtable from an immutable memtable.

It also renames mark_immutable() to freeze().

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@evenyag evenyag marked this pull request as ready for review February 4, 2024 12:33
v0y4g3r
v0y4g3r approved these changes Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v0y4g3r v0y4g3r merged commit dd6c235 into poc/compact-memtable Feb 5, 2024
23 of 24 checks passed
@v0y4g3r v0y4g3r deleted the feat/fork-memtable branch February 5, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v0y4g3r v0y4g3r v0y4g3r approved these changes

Assignees
No one assigned
Labels
Size: S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evenyag @v0y4g3r